Re: [PATCH 2/2] mingw: ensure temporary file handles are not inherited by child processes

Hi,

On Fri, 19 Aug 2016, Junio C Hamano wrote:

Eric Wong [off-list ref] writes:

quoted

I'd be more comfortable keeping the EINVAL check that got
snipped in your reply.  O_CLOEXEC can be defined to non-zero in
new userspace headers, but an older kernel chokes on it with
EINVAL.

Good point.  Thanks.

I tried to accomodate both of your suggestions by defining O_CLOEXEC
in git-compat-util.h unless defined earlier, and by handling EINVAL via
dropping O_CLOEXEC in a second call to open(). Please inspect the
interdiff of the upcoming iteration.

Ciao,
Dscho