2 messages, 2 authors, 2016-08-22 · open the first message on its own page
From: Junio C Hamano <hidden>
Date: 2016-08-19 15:59:19
Eric Wong [off-list ref] writes:
I'd be more comfortable keeping the EINVAL check that got snipped in your reply. O_CLOEXEC can be defined to non-zero in new userspace headers, but an older kernel chokes on it with EINVAL.
Good point. Thanks.
From: Johannes Schindelin <hidden>
Date: 2016-08-22 12:48:41
Hi, On Fri, 19 Aug 2016, Junio C Hamano wrote:
Eric Wong [off-list ref] writes:quoted
I'd be more comfortable keeping the EINVAL check that got snipped in your reply. O_CLOEXEC can be defined to non-zero in new userspace headers, but an older kernel chokes on it with EINVAL.Good point. Thanks.
I tried to accomodate both of your suggestions by defining O_CLOEXEC in git-compat-util.h unless defined earlier, and by handling EINVAL via dropping O_CLOEXEC in a second call to open(). Please inspect the interdiff of the upcoming iteration. Ciao, Dscho