Re: [PATCHv8 8/8] clone: recursive and reference option triggers submodule alternates
From: Stefan Beller <hidden>
Date: 2016-08-19 02:41:10
Subsystem:
the rest · Maintainer:
Linus Torvalds
Possibly related (same subject, not in this thread)
- 2016-08-23 · Re: [PATCHv8 8/8] clone: recursive and reference option triggers submodule alternates · Junio C Hamano <hidden>
- 2016-08-17 · [PATCHv8 8/8] clone: recursive and reference option triggers submodule alternates · Stefan Beller <hidden>
On Wed, Aug 17, 2016 at 5:17 PM, Junio C Hamano [off-list ref] wrote:
Stefan Beller [off-list ref] writes:quoted
and now with error handling of invalid options.Thanks.
Well this was not the end of the story. I sent that version out, before doing a final test run, because changing a few lines is trivial right? :( I'll resend with:
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index a1da3ea..a366757 100644
--- a/builtin/submodule--helper.c
+++ b/builtin/submodule--helper.c@@ -562,7 +562,7 @@ static void prepare_possible_alternates(const char *sm_name, if (!strcmp(sm_alternate, "superproject")) foreach_alt_odb(add_possible_reference_from_superproject, &sas); - else if (!strcmp(sm_alternate, "no") + else if (!strcmp(sm_alternate, "no")) ; /* do nothing */ else die(_("Value '%s' for submodule.alternateLocation is
not recognized"), sm_alternate);