Re: [PATCHv8 8/8] clone: recursive and reference option triggers submodule alternates
From: Junio C Hamano <hidden>
Date: 2016-08-23 16:13:00
Stefan Beller [off-list ref] writes:
On Wed, Aug 17, 2016 at 5:17 PM, Junio C Hamano [off-list ref] wrote:quoted
Stefan Beller [off-list ref] writes:quoted
and now with error handling of invalid options.Thanks.Well this was not the end of the story. I sent that version out, before doing a final test run, because changing a few lines is trivial right? :( I'll resend with:
Heh, my integration test caught it before pushing it out ;-).
quoted hunk
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c index a1da3ea..a366757 100644 --- a/builtin/submodule--helper.c +++ b/builtin/submodule--helper.c@@ -562,7 +562,7 @@ static void prepare_possible_alternates(const char *sm_name, if (!strcmp(sm_alternate, "superproject")) foreach_alt_odb(add_possible_reference_from_superproject, &sas); - else if (!strcmp(sm_alternate, "no") + else if (!strcmp(sm_alternate, "no")) ; /* do nothing */ else die(_("Value '%s' for submodule.alternateLocation isnot recognized"), sm_alternate);