Thread (40 messages) flat view 40 messages, 4 authors, 2016-08-15

Re: [PATCH 3/8] xdl_change_compact(): rename i to end

From: Jeff King <hidden>
Date: 2016-08-04 07:44:06

On Thu, Aug 04, 2016 at 12:00:31AM +0200, Michael Haggerty wrote:
Rename i to end, and alternate between using start and end as the
indexing variable as appropriate.

Rename ixref to end_matching_other.

Add some more comments.
I'd usually complain that there is too much "what" in your commit
message, but in this case, the diff really is hard to read. Having a
summary up front is nice.

There's no "why", but I imagine it is just "I had to do this to even
make sense of this function".

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help