Thread (67 messages) flat view 67 messages, 9 authors, 2016-08-07

Re: [PATCH v1 3/3] convert: add filter.<driver>.useProtocol option

From: Jeff King <hidden>
Date: 2016-07-26 20:02:11

On Sat, Jul 23, 2016 at 07:27:21AM +0000, Eric Wong wrote:
Jakub Narębski [off-list ref] wrote:
quoted
W dniu 2016-07-22 o 17:49, larsxschneider@gmail.com pisze:
quoted
+use strict;
+use warnings;
+use autodie;
autodie?
"set -e" for Perl (man autodie)

It's been a part of Perl for ages, but I've never used it
myself, either; I suppose it's fine for tests...
autodie has been around for a long time, but it only became part of the
perl core in v5.10.1 (according to Module::CoreList). I think the code
in perl/ requires only 5.8, but whenever we unconditionally use perl
without respect to NO_PERL (like in the test scripts), we usually shoot
for even antique versions of perl like 5.005.

So by those rules, we should avoid "autodie" here, though I wouldn't be
surprised if it takes a while for people to complain in practice (most
modern systems will have a recent enough perl, but it seems we go
through cycles where every few years somebody posts a bunch of patches
for ancient versions of IRIX or some other platform, cleaning up all of
these sorts of portability problems).

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help