Re: [PATCH v1 2/3] convert: modernize tests
From: Remi Galan Alfonso <hidden>
Date: 2016-07-26 15:09:55
Hi Lars, Sorry, minor nit that I noticed a couple of days ago but didn't comment on the moment and forgot until now. Lars Schneider [off-list ref] wrote:
Use `test_config` to set the config, check that files are empty with `test_must_be_empty`, compare files with `test_cmp`, and remove spaces after ">".
Considering how close it is to your patch, you might also want to remove spaces after '<'. There is only one occurrence in this file and it's in a line you are already modifying. See below:
quoted hunk ↗ jump to hunk
test_expect_success check ' - cmp test.o test && - cmp test.o test.t && + test_cmp test.o test && + test_cmp test.o test.t && # ident should be stripped in the repository git diff --raw --exit-code :test :test.i &&@@ -47,10 +47,10 @@ test_expect_success check ' embedded=$(sed -ne "$script" test.i) && test "z$id" = "z$embedded" && - git cat-file blob :test.t > test.r && + git cat-file blob :test.t >test.r && - ./rot13.sh < test.o > test.t && - cmp test.r test.t + ./rot13.sh < test.o >test.t &&
Here.
+ test_cmp test.r test.t '
Thanks, Rémi