Re: [PATCH] completion: complete --move for git branch

Ville Skyttä [off-list ref] writes:

On Mon, Jun 6, 2016 at 5:16 PM, Remi Galan Alfonso
[off-list ref] wrote:

quoted

Hi,

Ville Skyttä [off-list ref] writes:

quoted

         while [ $c -lt $cword ]; do
                 i="${words[c]}"
                 case "$i" in
-                -d|-m)        only_local_ref="y" ;;
-                -r)        has_r="y" ;;
+                -d|-m|--move)        only_local_ref="y" ;;

"While you're at it" you might want to do the same thing for
`--delete`.

I'm afraid the "while I'm at it" would never end if I start looking
deeper into missing things there, so I'd prefer this self contained
one I keep running into myself applied first.

I understand, though adding `--delete` here makes sense since there is
already the short-hand `-d` that is tested (like you added `--move`
since the short-hand `-m` is tested).
However adding it here means that we should also add it in completion
list below. Thinking about it, it might be better to have it in a
separate patch, so no further objections with this patch.

quoted

quoted

+                -r)                has_r="y" ;;

You are introducing an additional tab here that you probably didn't
want.

It was intentionally added it to keep "only_local_ref" and "has_r"
tab-aligned the way they already were.

Ah indeed, my bad, I didn't see it.

Thanks,
Rémi