Thread (5 messages) flat view 5 messages, 2 authors, 2016-08-09

Re: [PATCH] completion: complete --move for git branch

From: Ville Skyttä <hidden>
Date: 2016-06-16 02:19:45

On Mon, Jun 6, 2016 at 5:16 PM, Remi Galan Alfonso
[off-list ref] wrote:
Hi,

Ville Skyttä [off-list ref] writes:
quoted
         while [ $c -lt $cword ]; do
                 i="${words[c]}"
                 case "$i" in
-                -d|-m)        only_local_ref="y" ;;
-                -r)        has_r="y" ;;
+                -d|-m|--move)        only_local_ref="y" ;;
"While you're at it" you might want to do the same thing for
`--delete`.
I'm afraid the "while I'm at it" would never end if I start looking
deeper into missing things there, so I'd prefer this self contained
one I keep running into myself applied first.
quoted
+                -r)                has_r="y" ;;
You are introducing an additional tab here that you probably didn't
want.
It was intentionally added it to keep "only_local_ref" and "has_r"
tab-aligned the way they already were.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help