Re: Segfault in the attr stack
flat view
From: Stefan Beller <hidden>
Date: 2016-06-16 02:19:42
Possibly related (same subject, not in this thread)
- 2016-06-16 · Segfault in the attr stack · Stefan Beller <hidden>
- 2016-06-16 · Re: Segfault in the attr stack · Junio C Hamano <hidden>
- 2016-06-16 · Re: Segfault in the attr stack · Stefan Beller <hidden>
- 2016-06-16 · Re: Segfault in the attr stack · Junio C Hamano <hidden>
- 2016-06-16 · Re: Segfault in the attr stack · Stefan Beller <hidden>
On Thu, Jun 2, 2016 at 8:59 AM, Junio C Hamano [off-list ref] wrote:
Junio C Hamano [off-list ref] writes:quoted
quoted
quoted
Gaah, of course. This is coming from the cache preload codepath, where multiple threads try to run ce_path_match(). It used to be OK because pathspec magic never looked at attributes, but now it does, and attribute system is not thread-safe.I'll look into teaching a threadble interface to the attribute subsystem, but for now, this should get you unstuck, I think.
Thanks for looking into this! (I was about to do that if you would not have stepped up, as the bug only surfaces when using the pathspec labels.)
quoted hunk ↗ jump to hunk
+ /* Do not preload when pathspec uses non-threadable subsystems */ + if (pathspec && pathspec_is_non_threadable(pathspec)) + return; /* for now ... */
This fixes the problem for now; I'll look into the comma escaping then. Thanks, Stefan