Thread (25 messages) flat view 25 messages, 5 authors, 2016-06-16

Re: [PATCH 12/13] dir_iterator: new API for iterating over a directory tree

From: David Turner <hidden>
Date: 2016-06-16 02:19:40

On Mon, 2016-05-30 at 09:55 +0200, Michael Haggerty wrote:
+struct dir_iterator_level {
+	int initialized;
+
+	DIR *dir;
+
+	/*
+	 * The length of the directory part of refname at this level

"refname"? Isn't this was for directories?
+			if (lstat(iter->base.path.buf, &iter
->base.st) < 0)
+				continue; /* silently skip */
Should we warn on non-ENOENT errors here?
+/*
+ * End the iteration before it has been exhausted. Free the
reference
s/reference/directory/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help