Thread (9 messages) 9 messages, 3 authors, 2016-06-16

Re: [PATCH 2/2] bisect--helper: `bisect_voc` shell function in C

From: Pranit Bauva <hidden>
Date: 2016-06-16 02:19:22

On Sat, May 14, 2016 at 1:32 AM, Pranit Bauva [off-list ref] wrote:
Reimplement the `bisect_voc` shell function in C. This is a too small
function to be called as a subcommand though the working of this
function has been tested by calling it as a subcommand.

Mentored-by: Lars Schneider [off-list ref]
Mentored-by: Pranit Bauva [off-list ref]
I missed this. It should be
     "Mentored-by: Christian Couder [off-list ref]"
quoted hunk ↗ jump to hunk
Signed-off-by: Pranit Bauva <redacted>

---
The PR for testing of this function by the subcommand approach can be
found at:
https://github.com/pranitbauva1997/git/pull/5

Signed-off-by: Pranit Bauva <redacted>
---
 builtin/bisect--helper.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
index 87764fe..455f1cb 100644
--- a/builtin/bisect--helper.c
+++ b/builtin/bisect--helper.c
@@ -94,6 +94,16 @@ int bisect_log(void)
        return 0;
 }

+int bisect_voc(const char *term)
+{
+       if (!strcmp(term, "bad"))
+               printf("bad|new\n");
+       if (!strcmp(term, "good"))
+               printf("good|old\n");
+
+       return 0;
+}
+
 int cmd_bisect__helper(int argc, const char **argv, const char *prefix)
 {
        enum {
--
2.8.2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help