Re: [PATCH v4 15/16] branch: use ref-filter printing APIs

On Sat, Apr 16, 2016 at 5:41 AM, Stefan Beller [off-list ref] wrote:

quoted

 static int calc_maxwidth(struct ref_array *refs, int remote_bonus)
 {
        int i, max = 0;

@@ -432,7 +281,10 @@ static int calc_maxwidth(struct ref_array *refs, int remote_bonus)

                skip_prefix(it->refname, "refs/heads/", &desc);
                skip_prefix(it->refname, "refs/remotes/", &desc);
-               w = utf8_strwidth(desc);
+               if (it->kind == FILTER_REFS_DETACHED_HEAD)
+                       w = strlen(get_head_description());

get_head_description returns memory, which needs to be free'd.
(found by catching up on reading the coverity scan log. I see
you deleted get_head_description in another part of the patch;
nevertheless would you like to take care of this memleak?)

Seems like an easy fix. Will take care of it, Thanks :)

-- 
Regards,
Karthik Nayak