Thread (21 messages) flat view 21 messages, 3 authors, 2016-06-16

Re: [PATCH v4 15/16] branch: use ref-filter printing APIs

From: Stefan Beller <hidden>
Date: 2016-06-16 02:18:49

quoted hunk ↗ jump to hunk
 static int calc_maxwidth(struct ref_array *refs, int remote_bonus)
 {
        int i, max = 0;
@@ -432,7 +281,10 @@ static int calc_maxwidth(struct ref_array *refs, int remote_bonus)

                skip_prefix(it->refname, "refs/heads/", &desc);
                skip_prefix(it->refname, "refs/remotes/", &desc);
-               w = utf8_strwidth(desc);
+               if (it->kind == FILTER_REFS_DETACHED_HEAD)
+                       w = strlen(get_head_description());
get_head_description returns memory, which needs to be free'd.
(found by catching up on reading the coverity scan log. I see
you deleted get_head_description in another part of the patch;
nevertheless would you like to take care of this memleak?)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help