Re: [PATCH v3 3/4] builtin/verify-tag: move verification code to tag.c

On Sat, Apr 2, 2016 at 7:16 PM,  [off-list ref] wrote:

The PGP verification routine for tags could be accessed by other
commands that require it. We do this by moving it to the common tag.c
code. We rename the verify_tag() function to pgp_verify_tag() to avoid
conflicts with the mktag.c function.

Signed-off-by: Santiago Torres <redacted>
---
-       len = parse_signature(buf, size);
-
-       if (size == len) {
-               if (flags & GPG_VERIFY_VERBOSE)
-                       write_in_full(1, buf, len);
-               return error("no signature found");
-       }
[...]
+       payload_size = parse_signature(buf, size);
+
+       if (size == payload_size) {
+               write_in_full(1, buf, payload_size);
+               return error("No PGP signature found in this tag!");
+       }

Also, [1] asked why the moved code no longer respects
GPG_VERIFY_VERBOSE, and that question doesn't seem to be answered
either in the previous review thread or by this patch's commit
message. It's not clear at a casual glance why this change is
desirable.

[1]: http://article.gmane.org/gmane.comp.version-control.git/289977