Thread (24 messages) flat view 24 messages, 4 authors, 2016-06-16

Re: [PATCH v3 2/4] t/t7030-verify-tag.sh: Adds validation for multiple tags

From: Eric Sunshine <hidden>
Date: 2016-06-16 02:18:38

On Sun, Apr 3, 2016 at 12:40 AM, Jeff King [off-list ref] wrote:
In fact, I suspect you could replace the "GOODSIG" check as well by
doing something like:

  # verifying 3 tags in one invocation should be exactly like
  # verifying the 3 separately
  tags="fourth-signed sixth-signed seventh-signed"
  for i in $tags; do
          git verify-tag -v --raw $i || return 1
  done >expect.stdout 2>expect.stderr &&
  git verify-tag -v --raw $tags >actual.stdout 2>actual.stderr &&
  test_cmp expect.stdout actual.stdout &&
  test_cmp expect.stderr actual.stderr
Hmm, does [1] suggest that using test_cmp on stderr here would be
contraindicated?

[1]: http://article.gmane.org/gmane.comp.version-control.git/289077
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help