Re: [PATCH/RFC/GSoC 16/17] editor: implement git_sequence_editor() and launch_sequence_editor()

Hi Dscho,

On Tue, Mar 15, 2016 at 3:00 PM, Johannes Schindelin
[off-list ref] wrote:

On Sat, 12 Mar 2016, Paul Tan wrote:

quoted

---
 cache.h  |  1 +

No need to clutter cache.h with a function that is only to be used by the
sequencer. IOW let's make this static in sequencer.c.

The function needs to be implemented in editor.c because it would be
better for it to share the same code that launch_editor() uses
(implemented in this patch by splitting the logic into a static
function launch_specific_editor())

We could move the declaration to sequencer.h though.

I would also prefer pairing this short function with the change that
actually uses it (in my topic branches, I like to compile with -Werror,
which would result in a failure due to an unused function), in the same
patch.

Sure.

Regards,
Paul