Thread (53 messages) flat view 53 messages, 6 authors, 2016-06-15

Re: [PATCH/RFC/GSoC 16/17] editor: implement git_sequence_editor() and launch_sequence_editor()

From: Johannes Schindelin <hidden>
Date: 2016-06-15 23:08:44

Hi Paul,

On Sat, 12 Mar 2016, Paul Tan wrote:
Signed-off-by: Paul Tan <redacted>
This commit message is very short.
---
 cache.h  |  1 +
No need to clutter cache.h with a function that is only to be used by the
sequencer. IOW let's make this static in sequencer.c.

I would also prefer pairing this short function with the change that
actually uses it (in my topic branches, I like to compile with -Werror,
which would result in a failure due to an unused function), in the same
patch.

Ciao,
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help