Thread (25 messages) flat view 25 messages, 5 authors, 2016-06-15

Re: [PATCH v4 3/3] config: add '--show-origin' option to print the origin of a config value

From: Jeff King <hidden>
Date: 2016-06-15 23:08:14

On Mon, Feb 15, 2016 at 09:36:23PM +0000, Ramsay Jones wrote:
quoted
+test_expect_success '--show-origin stdin' '
+	cat >expect <<-\EOF &&
+		stdin:	user.custom=true
So, as with the previous patch, I think this should be:
		file:<stdin>	user.custom=true
That's ambiguous with a file named "<stdin>", which was the point of
having the two separate prefixes in the first place.

I think in practice we _could_ get by with an ambiguous output (it's not
like "<stdin>" is a common filename), but that was discussed earlier in
the thread, and Lars decided to go for something unambiguous.

That doesn't necessarily have to bleed over into the error messages,
though (which could continue to use "<stdin>" if we want to put in a
little extra code to covering the cases separately.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help