Thread (40 messages) flat view 40 messages, 3 authors, 2016-06-15

Re: [PATCH/RFC 04/10] ref-filter: skip deref specifier in match_atom_name()

From: Eric Sunshine <hidden>
Date: 2016-06-15 23:07:21

On Wed, Nov 11, 2015 at 2:44 PM, Karthik Nayak [off-list ref] wrote:
Signed-off-by: Karthik Nayak <redacted>
A bit of explanation about why this change is desirable would be
welcome. I'm guessing it's because a future patch is going to make
calls to match_atom_name() with the '*' deref indicator still attached
to the name, whereas existing code does not do so.
quoted hunk ↗ jump to hunk
---
diff --git a/ref-filter.c b/ref-filter.c
@@ -37,6 +37,10 @@ static int match_atom_name(const char *name, const char *atom_name, const char *
 {
        const char *body;

+       /*  skip the deref specifier*/
+       if (name[0] == '*')
+               name++;
+
        if (!skip_prefix(name, atom_name, &body))
                return 0; /* doesn't even begin with "atom_name" */
        if (!body[0]) {
--
2.6.2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help