Re: [PATCH v2] send-email: die if CA path doesn't exist

On Tue, Nov 24, 2015 at 06:35:36PM -0500, Jeff King wrote:

On Tue, Nov 24, 2015 at 11:31:40PM +0000, John Keeping wrote:

quoted

If the CA path isn't found it's most likely to indicate a
misconfiguration, in which case accepting any certificate is unlikely to
be the correct thing to do.

Thanks.

quoted

Changes since v1:
- add missing path to error message
- remove trailing '.' on error message since die appends "at
  /path/to/git-send-email line ..."

It won't if the error message ends with a newline. We seem to be wildly
inconsistent about that in send-email, though.

Interesting.  I think in this case it would definitely be better to add
the newline and avoid printing the location in the script, but it may
make more sense to have a separate pass over git-send-email.perl and fix
all of the die() calls.

I suspect that everything except the equivalent of BUG() should be
suppressing the location in a user-facing script like this.