[RFC/PATCH] send-email: die if CA path doesn't exist
From: John Keeping <hidden>
Date: 2016-06-15 23:07:16
Subsystem:
the rest · Maintainer:
Linus Torvalds
If the CA path isn't found it's most likely to indicate a misconfiguration, in which case accepting any certificate is unlikely to be the correct thing to do. Signed-off-by: John Keeping <redacted> --- git-send-email.perl | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/git-send-email.perl b/git-send-email.perl
index 8e4c0e1..e057051 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl@@ -1196,8 +1196,7 @@ sub ssl_verify_params { return (SSL_verify_mode => SSL_VERIFY_PEER(), SSL_ca_file => $smtp_ssl_cert_path); } else { - print STDERR "Not using SSL_VERIFY_PEER because the CA path does not exist.\n"; - return (SSL_verify_mode => SSL_VERIFY_NONE()); + die "CA path does not exist."; } }
--
2.6.3.462.gbe2c914