Thread (4 messages) 4 messages, 2 authors, 2016-06-15

Re: [PATCH v2 0/2] Fix interactive rebase when the editor saves with CR/LF

flat view

From: Johannes Schindelin <hidden>
Date: 2016-06-15 23:07:04

Hi Junio,

On Mon, 26 Oct 2015, Junio C Hamano wrote:
Johannes Schindelin [off-list ref] writes:
quoted
A simple test with CR/LF line endings in a script reveals that it is
pretty solid:

	x=a
	case "$x" in a) echo b;; esac

prints out 'b', as expected.
I do not see what this has to do with anything.
You probably missed the context. Brian pointed out that my patch said
"printf ''" when it should have said "printf '\n'". I responded that my
commit says the right thing, but somewhere along the lines of transforming
beautiful Git commits into mails it must have been lost.

The explanation you quoted is the essence of the problem of my script to
prepare mails for submission to the mailing list: the script works in
Bash, but fails in Dash. And as my script has the shebang "#!/bin/sh" and
as Ubuntu defaults to using the Dash as its /bin/sh, we now have the full
explanation why my first mail showed an incorrect patch.

Ciao,
Johannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help