Thread (4 messages) 4 messages, 2 authors, 2016-06-15

Re: [PATCH v2 0/2] Fix interactive rebase when the editor saves with CR/LF

flat view

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:07:03

Johannes Schindelin [off-list ref] writes:
A simple test with CR/LF line endings in a script reveals that it is
pretty solid:

	x=a
	case "$x" in a) echo b;; esac

prints out 'b', as expected.
I do not see what this has to do with anything.

The shell language parser when parsing a script may do the right
thing, but the bug I was alluding to was that your 'read' does not
seem to be removing the terminating <newline> (which is CRLF on your
platform) after reading a line before splitting the contents on the
line at IFS boundaries.
Again. If CR has no place in IFS, why does LF have a place in IFS? It
makes *no* sense to argue for one and against the other.
See my message to Matthieu.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help