Re: [PATCH v3 23/34] mailinfo: move [ps]_hdr_data to struct mailinfo
From: Stefan Beller <hidden>
Date: 2016-06-15 23:07:01
On Mon, Oct 19, 2015 at 12:28 AM, Junio C Hamano [off-list ref] wrote:
quoted hunk ↗ jump to hunk
@@ -733,7 +733,7 @@ static int handle_commit_msg(struct mailinfo *mi, struct strbuf *line) } if (mi->use_inbody_headers && mi->header_stage) { - mi->header_stage = check_header(mi, line, s_hdr_data, 0); + mi->header_stage = check_header(mi, line, mi->s_hdr_data, 0);
Would it make sense to get rid of the third argument for check_header instead? We already pass in mi, so check_header can access s_hdr_data?
if (mi->header_stage)