Thread (104 messages) 104 messages, 3 authors, 2016-06-15
STALE3644d

[PATCH 01/26] mailinfo: remove a no-op call convert_to_utf8(it, "")

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:06:51
Subsystem: the rest · Maintainer: Linus Torvalds

The called function checks if the second parameter is either a NULL
or an empty string at the very beginning and returns without doing
anything.  Remove the useless call.

Signed-off-by: Junio C Hamano <redacted>
---
 builtin/mailinfo.c | 5 -----
 1 file changed, 5 deletions(-)
diff --git a/builtin/mailinfo.c b/builtin/mailinfo.c
index 169ee54..330bef4 100644
--- a/builtin/mailinfo.c
+++ b/builtin/mailinfo.c
@@ -612,11 +612,6 @@ static void decode_header(struct strbuf *it)
 {
 	if (decode_header_bq(it))
 		return;
-	/* otherwise "it" is a straight copy of the input.
-	 * This can be binary guck but there is no charset specified.
-	 */
-	if (metainfo_charset)
-		convert_to_utf8(it, "");
 }
 
 static void decode_transfer_encoding(struct strbuf *line)
-- 
2.6.1-320-g86a1181
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help