Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH 6/9] ref-filter: introduce format_ref_array_item()

From: Matthieu Moy <hidden>
Date: 2016-06-15 23:06:46

Karthik Nayak [off-list ref] writes:
The problem is with colors which tag.c doesn't use by default.
Here we need to print colors only if we're printing to a tty which supports
colors.
Ah, and tag --format '%(color:...)' does not do the tty autodetection.
which does not play well with the implementation of --column as done
in tag.c. Where, If I'm not wrong the --column option captures all
output, formats it and then prints it to stdout. Hence when using
colors, we're told that the printing isn't done to a tty which
supports colors, hence we lose out on colors.
What I don't understand is how --column is different from --no-column
wrt colors.

In any case, this should be explained better in comments.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help