Re: [PATCH 6/9] ref-filter: introduce format_ref_array_item()

Karthik Nayak [off-list ref] writes:

The problem is with colors which tag.c doesn't use by default.
Here we need to print colors only if we're printing to a tty which supports
colors.

Ah, and tag --format '%(color:...)' does not do the tty autodetection.

which does not play well with the implementation of --column as done
in tag.c. Where, If I'm not wrong the --column option captures all
output, formats it and then prints it to stdout. Hence when using
colors, we're told that the printing isn't done to a tty which
supports colors, hence we lose out on colors.

What I don't understand is how --column is different from --no-column
wrt colors.

In any case, this should be explained better in comments.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

On Mon, Oct 5, 2015 at 2:19 PM, Matthieu Moy
[off-list ref] wrote:

Karthik Nayak [off-list ref] writes:

quoted

which does not play well with the implementation of --column as done
in tag.c. Where, If I'm not wrong the --column option captures all
output, formats it and then prints it to stdout. Hence when using
colors, we're told that the printing isn't done to a tty which
supports colors, hence we lose out on colors.

What I don't understand is how --column is different from --no-column
wrt colors.

In any case, this should be explained better in comments.

Well, If we use column the way we do in tag.c then it'll replace the tty
and color will not print color because it will assume the output tty doesn't
support colors.

I hope that's what you're asking

-- 
Regards,
Karthik Nayak