Re: [PATCH] show-ref: place angle brackets around variables in usage string
From: Philip Oakley <hidden>
Date: 2016-06-15 23:06:20
From: "Alex Henrie" <redacted>
quoted hunk ↗ jump to hunk
Signed-off-by: Alex Henrie <redacted> --- builtin/show-ref.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/builtin/show-ref.c b/builtin/show-ref.c index dfbc314..131ef28 100644 --- a/builtin/show-ref.c +++ b/builtin/show-ref.c@@ -8,7 +8,7 @@static const char * const show_ref_usage[] = { N_("git show-ref [-q | --quiet] [--verify] [--head] [-d | --dereference] [-s | --hash[=<n>]] [--abbrev[=<n>]] [--tags] [--heads] [--] [<pattern>...]"), - N_("git show-ref --exclude-existing[=pattern] < ref-list"), + N_("git show-ref --exclude-existing[=<pattern>] < <ref-list>"),
Should the '<' stdin redirection be shown? It looks (at first glance) as if this gained a double '< <' at the beginning of 'ref-list', rather than being a clean indication of the redirection. Perhaps change 'ref-list' to 'ref-list-file' for a slight improvement in clarity - this it's only occurance, and the redirection would best match a file.
NULL }; -- 2.5.0
-- Philip (will be offline for 4 days)