Re: [PATCH] Correctly close config file handle in case of error

Without this patch there might be open file handle leaks.

Signed-off-by: Sven Strickroth <redacted>
Signed-off-by: Sup Yut Sum <redacted>
---

diff --git a/config.c b/config.c
index 9fd275f..8138d5d 100644
--- a/config.c
+++ b/config.c

@@ -2065,6 +2065,7 @@ int git_config_set_multivar_in_file(const char

*config_filename,
                        goto out_free;
                }
                close(in_fd);
+               in_fd = -1;

                if (chmod(lock->filename.buf, st.st_mode & 07777) < 0) {
                        error("chmod on %s failed: %s",

@@ -2148,6 +2149,8 @@ out_free:
        free(filename_buf);
        if (contents)
                munmap(contents, contents_sz);
+       if (in_fd >= 0)
+               close(in_fd);
        return ret;

 write_err_out:
--