Thread (9 messages) flat view 9 messages, 2 authors, 2016-06-15
DORMANTno replies

[PATCH] Close config file handle if the entry to unset is not found

From: Sven Strickroth <hidden>
Date: 2016-06-15 23:06:11
Subsystem: the rest · Maintainer: Linus Torvalds

Without this patch there might be open handle leaks.

Signed-off-by: Sup Yut Sum <redacted>
Signed-off-by: Sven Strickroth <redacted>
---
 config.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/config.c b/config.c
index 9fd275f..89b49e3 100644
--- a/config.c
+++ b/config.c
@@ -2048,6 +2048,7 @@ int git_config_set_multivar_in_file(const char *config_filename,
 		if ((store.seen == 0 && value == NULL) ||
 				(store.seen > 1 && multi_replace == 0)) {
 			ret = CONFIG_NOTHING_SET;
+			close(in_fd);
 			goto out_free;
 		}
 
-- 
Best regards,
 Sven Strickroth
 PGP key id F5A9D4C4 @ any key-server
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help