Thread (30 messages) flat view 30 messages, 4 authors, 2016-06-15

Re: [PATCH 06/13] delete_refs(): convert error message to lower case

From: Stefan Beller <hidden>
Date: 2016-06-15 23:05:12

On Mon, Jun 8, 2015 at 4:45 AM, Michael Haggerty [off-list ref] wrote:
This string is going to have to be re-internationalized anyway because
of the previous commit. So while we're at it, we might as well convert
it to lower case as per our usual practice.
Although the previous patch and this are addressing two slightly
different things,
we may want to squash this into the previous without dropping any of
the commit message?
(It might make reviewing easier, I'd assume)
quoted hunk ↗ jump to hunk
Signed-off-by: Michael Haggerty <redacted>
---
 refs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/refs.c b/refs.c
index 2a2a06d..a10aba8 100644
--- a/refs.c
+++ b/refs.c
@@ -2827,7 +2827,7 @@ int delete_refs(struct string_list *refnames)
                const char *refname = refnames->items[i].string;

                if (delete_ref(refname, NULL, 0))
-                       result |= error(_("Could not remove reference %s"), refname);
+                       result |= error(_("could not remove reference %s"), refname);
        }

        return result;
--
2.1.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help