Thread (3 messages) flat view 3 messages, 2 authors, 2016-06-15

Re: [PATCH/RFCv3 2/2] git rebase -i: warn about removed commits

From: Remi Galan Alfonso <hidden>
Date: 2016-06-15 23:05:07

Matthieu Moy [off-list ref] writes: 
quoted
Ideally, you would check the list of commits displayed too. If the 
commits sha1 are stable, this should be easy to do. If it's too hard to 
test, I'd say its not worth the trouble, but others may disagree. 
Originally I chose not to check if the SHA-1 were corrects since 
check_commits was called right after expand_todo_ids and I thought 
that expand_todo_ids checked them, but from what I understand, it 
doesn't seem to check if the SHA-1 are commits, I could be wrong 
though. 
Ignore this email, I completely misunderstood the email I was
responding to. 
(Mailer that doesn't show the quotes by default) 

Rémi 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help