Thread (3 messages) flat view 3 messages, 2 authors, 2016-06-15

Re: [PATCH/RFCv3 2/2] git rebase -i: warn about removed commits

From: Matthieu Moy <hidden>
Date: 2016-06-15 23:05:07

Remi Galan Alfonso [off-list ref] writes:
Checking that the warning was correctly displayed like in the test for
"warn" if I understood correctly. About that, is checking that the
first line is "Warning: some commits may have been dropped
accidentally." (like in the test for "warn") enough, or should I check
that the commit displayed as removed is the correct one?
Ideally, you would check the list of commits displayed too. If the
commits sha1 are stable, this should be easy to do. If it's too hard to
test, I'd say its not worth the trouble, but others may disagree.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help