Re: [PATCH v3] sha1_file: pass empty buffer to index empty file
From: Jeff King <hidden>
Date: 2016-06-15 23:04:49
Possibly related (same subject, not in this thread)
- 2016-06-15 · Re: [PATCH v3] sha1_file: pass empty buffer to index empty file · Jeff King <hidden>
- 2016-06-15 · Re: [PATCH v3] sha1_file: pass empty buffer to index empty file · Jeff King <hidden>
- 2016-06-15 · Re: [PATCH v3] sha1_file: pass empty buffer to index empty file · Junio C Hamano <hidden>
- 2016-06-15 · Re: [PATCH v3] sha1_file: pass empty buffer to index empty file · Junio C Hamano <hidden>
- 2016-06-15 · Re: [PATCH v3] sha1_file: pass empty buffer to index empty file · Jeff King <hidden>
On Sun, May 17, 2015 at 12:10:49PM -0700, Junio C Hamano wrote:
quoted hunk ↗ jump to hunk
I spoke too fast X-<. "while sh t0021-*.sh; do :; done" dies after a few iterations and with this squashed in it doesn't. t/t0021-conversion.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/t/t0021-conversion.sh b/t/t0021-conversion.sh index 42e6423..b778faf 100755 --- a/t/t0021-conversion.sh +++ b/t/t0021-conversion.sh@@ -218,7 +218,7 @@ test_expect_success "filter: clean empty file" ' ' test_expect_success "filter: smudge empty file" ' - git config filter.empty-in-repo.clean true && + git config filter.empty-in-repo.clean "cat >/dev/null" &&
Hmm, I thought we turned off SIGPIPE when writing to filters these days.
Looks like we still complain if we get EPIPE, though. I feel like it
should be the filter's business whether it wants to consume all of the
input or not[1], and we should only be checking its exit status.
-Peff
[1] As a practical example, consider a file format that has a lot of
cruft at the end. The clean filter would want to read only to the
start of the cruft, and then stop for reasons of efficiency.