Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH v3] sha1_file: pass empty buffer to index empty file

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:04:50

Jeff King [off-list ref] writes:
Your revised patch 2 looks good to me. I think you could test it more
reliably by simply adding a larger file, like:

  test-genrandom foo $((128 * 1024 + 1)) >big &&
  echo 'big filter=epipe' >.gitattributes &&
  git config filter.epipe.clean true &&
  git add big

The worst case if you get the size of the pipe buffer too small is that
the test will erroneously pass, but that is OK. As long as one person
has a reasonable-sized buffer, they will complain to the list
eventually. :)
Yeah, I like it.  It was lazy of me not to add a new test.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help