Re: [PATCH 1/3] t7300: add tests to document behavior of clean and nested git

On 2015-04-07 21.40, Eric Sunshine wrote:

On Mon, Apr 6, 2015 at 7:48 AM, Erik Elfström [off-list ref] wrote:

quoted

Signed-off-by: Erik Elfström <redacted>
---

diff --git a/t/t7300-clean.sh b/t/t7300-clean.sh
index 99be5d9..cfdf6d4 100755
--- a/t/t7300-clean.sh
+++ b/t/t7300-clean.sh

@@ -455,6 +455,88 @@ test_expect_success 'nested git work tree' '
+test_expect_success 'giving path in nested git work tree will remove it' '
+       rm -fr foo &&
+       mkdir foo &&
+       (
+               cd foo &&
+               git init &&
+               mkdir -p bar/baz &&
+               cd bar/baz &&
+               >hello.world

In my earlier review, I utterly forgot to  mention the broken &&-chain
here and throughout the patch.

quoted

+               git add . &&
+               git commit -a -m nested
+       ) &&

Beside that, all "cd" commands should be done within an own sub-shell.
In other words, something like this:
		mkdir -p bar/baz &&
		(
               		cd bar/baz &&
               		>hello.world &&
               		git add . &&
               		git commit -a -m nested
		)
Side note:
Needed to drop Eric:
An error occurred while sending mail. The mail server responded:  Requested action not taken: mailbox unavailable
invalid DNS MX or A/AAAA resource record. Please check the message recipient sunshine@sunshineco.com and try again.