Re: [PATCH v2 04/10] archive.c: convert to use struct object_id

On Wed, Mar 11, 2015 at 03:20:08PM +0100, Michael Haggerty wrote:

On 03/08/2015 12:23 AM, brian m. carlson wrote:

quoted

 struct directory {
 	struct directory *up;
-	unsigned char sha1[20];
+	unsigned char sha1[GIT_SHA1_RAWSZ];

This is a local struct, and I think it is only a three-line change to
change the sha1 member to

       struct object_id oid;

Though perhaps you are delaying that change for some concrete reason.

No, I just overlooked it.  I'll fix that in the re-roll.
-- 
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187