Re: [PATCH v2 04/10] archive.c: convert to use struct object_id
From: Michael Haggerty <hidden>
Date: 2016-06-15 23:04:08
On 03/08/2015 12:23 AM, brian m. carlson wrote:
quoted hunk ↗ jump to hunk
Convert a hard-coded 20 as well. Signed-off-by: brian m. carlson <redacted> --- archive.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)diff --git a/archive.c b/archive.c index 96057ed..46d9025 100644 --- a/archive.c +++ b/archive.c@@ -101,7 +101,7 @@ static void setup_archive_check(struct git_attr_check *check) struct directory { struct directory *up; - unsigned char sha1[20]; + unsigned char sha1[GIT_SHA1_RAWSZ];
This is a local struct, and I think it is only a three-line change to
change the sha1 member to
struct object_id oid;
Though perhaps you are delaying that change for some concrete reason.
[...]
Michael -- Michael Haggerty mhagger@alum.mit.edu