Re: [PATCH] run-command: use void to declare that functions take no parameters
From: Junio C Hamano <hidden>
Date: 2016-06-15 23:02:54
Possibly related (same subject, not in this thread)
- 2016-06-15 · [PATCH] run-command: use void to declare that functions take no parameters · René Scharfe <hidden>
- 2016-06-15 · Re: [PATCH] run-command: use void to declare that functions take no parameters · Junio C Hamano <hidden>
René Scharfe [off-list ref] writes:
Explicitly declare that git_atexit_dispatch() and git_atexit_clear() take no parameters instead of leaving their parameter list empty and thus unspecified. Signed-off-by: Rene Scharfe <redacted> ---
Thanks. I was kind of surprised after running a git blame to find that this is a recent thing, and the same patch looked quite substandard with numerious style violations, and I somehow managed to let them slip in X-<. Perhaps I was having a bad day or something...
quoted hunk
run-command.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/run-command.c b/run-command.c index 79a0a76..a476999 100644 --- a/run-command.c +++ b/run-command.c@@ -636,7 +636,7 @@ static struct { static int git_atexit_installed; -static void git_atexit_dispatch() +static void git_atexit_dispatch(void) { size_t i;@@ -644,7 +644,7 @@ static void git_atexit_dispatch() git_atexit_hdlrs.handlers[i-1](); } -static void git_atexit_clear() +static void git_atexit_clear(void) { free(git_atexit_hdlrs.handlers); memset(&git_atexit_hdlrs, 0, sizeof(git_atexit_hdlrs));