Re: [PATCH v5 05/35] rollback_lock_file(): set fd to -1

Jonathan Nieder wrote:

Michael Haggerty wrote:

quoted

--- a/lockfile.c
+++ b/lockfile.c

@@ -276,7 +276,7 @@ void rollback_lock_file(struct lock_file *lk)
 		return;
 
 	if (lk->fd >= 0)
-		close(lk->fd);
+		close_lock_file(lk);

Doesn't need to be guarded by the 'if'.

Err, yes it does.

Why doesn't close_lock_file bail out early when fd < 0?

In any case,
Reviewed-by: Jonathan Nieder <redacted>