Thread (73 messages) 73 messages, 3 authors, 2016-06-15

[PATCH v5 03/35] rollback_lock_file(): do not clear filename redundantly

STALE3760d REVIEWED: 1 (0M)

From: Michael Haggerty <hidden>
Date: 2016-06-15 23:02:32
Subsystem: the rest · Maintainer: Linus Torvalds

Revision v5 of 6 in this series; 1 review trailer.

Revisions (6)
  1. v2 [diff vs current]
  2. v3 [diff vs current]
  3. v4 [diff vs current]
  4. v5 current
  5. v6 [diff vs current]
  6. v7 [diff vs current]
It is only necessary to clear the lock_file's filename field if it was
not already clear.

Signed-off-by: Michael Haggerty <redacted>
Reviewed-by: Ronnie Sahlberg <redacted>
---
 lockfile.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lockfile.c b/lockfile.c
index f1ce154..a548e08 100644
--- a/lockfile.c
+++ b/lockfile.c
@@ -276,6 +276,6 @@ void rollback_lock_file(struct lock_file *lk)
 		if (lk->fd >= 0)
 			close(lk->fd);
 		unlink_or_warn(lk->filename);
+		lk->filename[0] = 0;
 	}
-	lk->filename[0] = 0;
 }
-- 
2.1.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help