Thread (2 messages) 2 messages, 2 authors, 2016-06-15

Re: git format-patch --in-reply-to allows header injection. Intended?

From: Niklas Hambüchen <hidden>
Date: 2016-06-15 23:02:26

On 04/09/14 23:36, Junio C Hamano wrote:
While I do not think of a reason to specify such a string to the
in-reply-to option (I'd rather edit the output in the editor if I
wanted to do anything fancy [*1*]), I do not think there is a reason
why you want to add a code to forbid such use, either.
My question was to find out whether I can pass untrusted user input to
--in-reply-to and expect that no header beyond "In-Reply-To" and
"References" is modified, but your answer makes clear that I cannot.

A possible alternative might have been that git verifies that the input
to --in-reply-to matches the format specified RFC2822 (section 3.6.4.).

Thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help