Thread (3 messages) 3 messages, 3 authors, 2d ago
WARM2d

[PATCH] p5551: fix repeated runs with update-ref --no-deref

From: Jon Simons <hidden>
Date: 2026-09-26 18:16:51
Subsystem: the rest · Maintainer: Linus Torvalds

Update p5551-fetch-rescan.sh to pass `--no-deref` when deleting child
test refs before each measured `git fetch`.  Otherwise, for repeated
runs, the second iteration will fail with:

    fatal: multiple updates for 'refs/remotes/origin/master' (including
    one via symref 'refs/remotes/origin/HEAD') are not allowed

Starting with 3f763ddf28 (fetch: set remote/HEAD if it does not exist,
2024-11-22), `git fetch` instantiates the HEAD symref.

The test, introduced in 7893bf1720 (p5551: add a script to test fetch
pack-dir rescans, 2017-11-20), predates that.

Signed-off-by: Jon Simons <redacted>
---
 t/perf/p5551-fetch-rescan.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/perf/p5551-fetch-rescan.sh b/t/perf/p5551-fetch-rescan.sh
index b99dc23e32..0b3ff632fc 100755
--- a/t/perf/p5551-fetch-rescan.sh
+++ b/t/perf/p5551-fetch-rescan.sh
@@ -45,7 +45,7 @@ test_perf 'fetch' '
 	(
 		cd child &&
 		$MODERN_GIT for-each-ref --format="delete %(refname)" refs/remotes |
-		$MODERN_GIT update-ref --stdin &&
+		$MODERN_GIT update-ref --stdin --no-deref &&
 		rm -vf .git/objects/$(echo $obj | sed "s|^..|&/|") &&
 
 		git fetch
base-commit: 0f8e75abebff0877cae681a3d5ff31ac47f54220
-- 
2.55.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help