[PATCH v20 00/48] Use ref transactions · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v20 02/48] refs.c: ref_transaction_commit should not free the transaction · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v20 07/48] lockfile.c: make lock_file return a meaningful errno on failurei · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v20 07/48] lockfile.c: make lock_file return a meaningful errno on failurei · Michael Haggerty <hidden> · 2016-06-15
[PATCH v20 04/48] refs.c: allow passing NULL to ref_transaction_free · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v20 05/48] refs.c: add a strbuf argument to ref_transaction_commit for error logging · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v20 06/48] lockfile.c: add a new public function unable_to_lock_message · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v20 12/48] refs.c: commit_packed_refs to return a meaningful errno on failure · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v20 08/48] refs.c: add an err argument to repack_without_refs · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v20 15/48] refs.c: make ref_update_reject_duplicates take a strbuf argument for errors · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v20 03/48] refs.c: constify the sha arguments for ref_transaction_create|delete|update · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v20 01/48] refs.c: remove ref_transaction_rollback · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v20 40/48] refs.c: add an err argument to delete_ref_loose · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v20 40/48] refs.c: add an err argument to delete_ref_loose · Michael Haggerty <hidden> · 2016-06-15
Re: [PATCH v20 40/48] refs.c: add an err argument to delete_ref_loose · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v20 48/48] refs.c: make write_ref_sha1 static · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v20 38/48] refs.c: make prune_ref use a transaction to delete the ref · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v20 39/48] refs.c: make delete_ref use a transaction · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v20 39/48] refs.c: make delete_ref use a transaction · Michael Haggerty <hidden> · 2016-06-15
Re: [PATCH v20 39/48] refs.c: make delete_ref use a transaction · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v20 42/48] refs.c: pass NULL as *flags to read_ref_full · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v20 47/48] fetch.c: change s_update_ref to use a ref transaction · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v20 43/48] refs.c: move the check for valid refname to lock_ref_sha1_basic · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v20 43/48] refs.c: move the check for valid refname to lock_ref_sha1_basic · Michael Haggerty <hidden> · 2016-06-15
Re: [PATCH v20 43/48] refs.c: move the check for valid refname to lock_ref_sha1_basic · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v20 43/48] refs.c: move the check for valid refname to lock_ref_sha1_basic · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v20 43/48] refs.c: move the check for valid refname to lock_ref_sha1_basic · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v20 43/48] refs.c: move the check for valid refname to lock_ref_sha1_basic · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v20 43/48] refs.c: move the check for valid refname to lock_ref_sha1_basic · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v20 43/48] refs.c: move the check for valid refname to lock_ref_sha1_basic · Michael Haggerty <hidden> · 2016-06-15
Re: [PATCH v20 43/48] refs.c: move the check for valid refname to lock_ref_sha1_basic · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v20 43/48] refs.c: move the check for valid refname to lock_ref_sha1_basic · Jonathan Nieder <hidden> · 2016-06-15
Re: [PATCH v20 43/48] refs.c: move the check for valid refname to lock_ref_sha1_basic · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v20 43/48] refs.c: move the check for valid refname to lock_ref_sha1_basic · Michael Haggerty <hidden> · 2016-06-15
Re: [PATCH v20 43/48] refs.c: move the check for valid refname to lock_ref_sha1_basic · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v20 44/48] refs.c: call lock_ref_sha1_basic directly from commit · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v20 44/48] refs.c: call lock_ref_sha1_basic directly from commit · Michael Haggerty <hidden> · 2016-06-15
[PATCH v20 46/48] refs.c: propagate any errno==ENOTDIR from _commit back to the callers · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v20 45/48] refs.c: pass a skip list to name_conflict_fn · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v20 41/48] refs.c: pass the ref log message to _create/delete/update instead of _commit · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v20 41/48] refs.c: pass the ref log message to _create/delete/update instead of _commit · Michael Haggerty <hidden> · 2016-06-15
[PATCH v20 29/48] branch.c: use ref transaction for all ref updates · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v20 32/48] fast-import.c: use a ref transaction when dumping tags · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v20 37/48] refs.c: remove lock_ref_sha1 · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v20 37/48] refs.c: remove lock_ref_sha1 · Michael Haggerty <hidden> · 2016-06-15
[PATCH v20 36/48] refs.c: remove the update_ref_write function · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v20 26/48] commit.c: use ref transactions for updates · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v20 25/48] replace.c: use the ref transaction functions for updates · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v20 25/48] replace.c: use the ref transaction functions for updates · Michael Haggerty <hidden> · 2016-06-15
Re: [PATCH v20 25/48] replace.c: use the ref transaction functions for updates · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v20 30/48] refs.c: change update_ref to use a transaction · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v20 30/48] refs.c: change update_ref to use a transaction · Michael Haggerty <hidden> · 2016-06-15
Re: [PATCH v20 30/48] refs.c: change update_ref to use a transaction · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v20 35/48] refs.c: remove the update_ref_lock function · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v20 33/48] walker.c: use ref transaction for ref updates · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v20 33/48] walker.c: use ref transaction for ref updates · Michael Haggerty <hidden> · 2016-06-15
Re: [PATCH v20 33/48] walker.c: use ref transaction for ref updates · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v20 31/48] receive-pack.c: use a reference transaction for updating the refs · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v20 31/48] receive-pack.c: use a reference transaction for updating the refs · Michael Haggerty <hidden> · 2016-06-15
Re: [PATCH v20 31/48] receive-pack.c: use a reference transaction for updating the refs · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v20 23/48] refs.c: add transaction.status and track OPEN/CLOSED/ERROR · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v20 23/48] refs.c: add transaction.status and track OPEN/CLOSED/ERROR · Michael Haggerty <hidden> · 2016-06-15
Re: [PATCH v20 23/48] refs.c: add transaction.status and track OPEN/CLOSED/ERROR · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v20 19/48] refs.c: change ref_transaction_update() to do error checking and return status · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v20 21/48] refs.c: update ref_transaction_delete to check for error and return status · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v20 11/48] refs.c: make remove_empty_directories always set errno to something sane · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v20 16/48] refs.c: make update_ref_write update a strbuf on failure · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v20 24/48] tag.c: use ref transactions when doing updates · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v20 24/48] tag.c: use ref transactions when doing updates · Michael Haggerty <hidden> · 2016-06-15
[PATCH v20 14/48] refs.c: log_ref_write should try to return meaningful errno · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v20 17/48] update-ref: use err argument to get error from ref_transaction_commit · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v20 13/48] refs.c: make resolve_ref_unsafe set errno to something meaningful on error · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v20 13/48] refs.c: make resolve_ref_unsafe set errno to something meaningful on error · Karsten Blees <hidden> · 2016-06-15
[PATCH v20 22/48] refs.c: make ref_transaction_begin take an err argument · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v20 22/48] refs.c: make ref_transaction_begin take an err argument · Michael Haggerty <hidden> · 2016-06-15
Re: [PATCH v20 22/48] refs.c: make ref_transaction_begin take an err argument · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v20 10/48] refs.c: verify_lock should set errno to something meaningful · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v20 34/48] refs.c: make lock_ref_sha1 static · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v20 09/48] refs.c: make sure log_ref_setup returns a meaningful errno · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v20 28/48] fast-import.c: change update_branch to use ref transactions · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v20 20/48] refs.c: change ref_transaction_create to do error checking and return status · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v20 20/48] refs.c: change ref_transaction_create to do error checking and return status · Michael Haggerty <hidden> · 2016-06-15
Re: [PATCH v20 20/48] refs.c: change ref_transaction_create to do error checking and return status · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v20 27/48] sequencer.c: use ref transactions for all ref updates · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v20 27/48] sequencer.c: use ref transactions for all ref updates · Michael Haggerty <hidden> · 2016-06-15
Re: [PATCH v20 27/48] sequencer.c: use ref transactions for all ref updates · Ronnie Sahlberg <hidden> · 2016-06-15
[PATCH v20 18/48] refs.c: remove the onerr argument to ref_transaction_commit · Ronnie Sahlberg <hidden> · 2016-06-15
Re: [PATCH v20 00/48] Use ref transactions · Michael Haggerty <hidden> · 2016-06-15
Re: [PATCH v20 00/48] Use ref transactions · Ronnie Sahlberg <hidden> · 2016-06-15

Re: [PATCH v20 37/48] refs.c: remove lock_ref_sha1

From: Michael Haggerty <hidden>
Date: 2016-06-15 23:01:50

On 06/20/2014 04:43 PM, Ronnie Sahlberg wrote:

lock_ref_sha1 was only called from one place in refc.c and only provided
a check that the refname was sane before adding back the initial "refs/"
part of the ref path name, the initial "refs/" that this caller had already
stripped off before calling lock_ref_sha1.
[...]

I'm especially glad to see this ugly function disappear!

Michael

-- 
Michael Haggerty
mhagger@alum.mit.edu

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help