Re: [GUILT 04/28] Allow "guilt import-commit" to run from a dir which contains spaces.

On Sun, Mar 23, 2014 at 10:13:53PM +0100, Per Cederqvist wrote:

On Sun, Mar 23, 2014 at 9:07 PM, Jeff Sipek [off-list ref] wrote:

quoted

On Sun, Mar 23, 2014 at 08:57:08PM +0100, Per Cederqvist wrote:

quoted

On Sun, Mar 23, 2014 at 6:04 PM, Jeff Sipek [off-list ref] wrote:

quoted

On Fri, Mar 21, 2014 at 08:31:42AM +0100, Per Cederqvist wrote:

quoted

Signed-off-by: Per Cederqvist <redacted>
---
 guilt-import-commit | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/guilt-import-commit b/guilt-import-commit
index 20dcee2..9488ded 100755
--- a/guilt-import-commit
+++ b/guilt-import-commit

@@ -23,7 +23,7 @@ if ! must_commit_first; then
 fi

 disp "About to begin conversion..." >&2
-disp "Current head: `cat $GIT_DIR/refs/heads/\`git_branch\``" >&2
+disp "Current head: `cat \"$GIT_DIR\"/refs/heads/\`git_branch\``" >&2

I wonder if it'd be better to use 'git rev-parse' here instead of looking at
the refs directly.

IOW,

disp "Current head: `git rev-parse \`git_branch\``" >&2

That is probably a good idea. I only made the minimum change
required to get the test suite to pass.

I totally understand.

quoted

quoted

Maybe even $() instead of the inner `` to clean it up some more.

Yes, given that that construct is already used in several places
it is apparently portable enough for guilt. (I guess nobody uses
/bin/sh on Solaris to run guilt. It doesn't support the $(...)
construct.)

Hrm?  I'm using OpenIndiana (OpenSolaris derivative) and my /bin/sh seems to
be a symlink to ksh93.  What version of Solaris are you seeing this behavior
on?

Solaris 10:

Last login: Sun Mar 23 20:53:28 2014 from c80-217-121-12.
Sun Microsystems Inc.   SunOS 5.10      Generic January 2005
You have mail.
500 ceder@bacon> uname -a
SunOS bacon 5.10 Generic_147147-26 sun4u sparc SUNW,Sun-Fire-15000
501 ceder@bacon> /bin/sh
$ echo `id`
uid=105(ceder) gid=20105(ceder)
$ echo $(id)
syntax error: `(' unexpected

/bin/sh is a symlink to /sbin/sh.

On Solaris 10, you are supposed to use /usr/xpg4/bin/sh if you want
a competent standards-compliant shell. /bin/sh is provided as a very
backward-compatible shell.

Ok, I finally got back to this series...

I'd say let's use the nested ``.

Jeff.

-- 
Hegh QaQ law'
quvHa'ghach QaQ puS