Re: [PATCH v2 2/3][GSOC] diff: use is_dot_or_dotdot() instead of strcmp()
From: Eric Sunshine <hidden>
Date: 2016-06-15 23:00:23
On Wed, Mar 19, 2014 at 7:23 AM, Hiroyuki Sano [off-list ref] wrote:
Subject: diff: use is_dot_or_dotdot() instead of strcmp()
You probably meant 'diff-no-index' rather than 'diff'.
You could make the subject a bit more explanatory by saying:
use is_dot_or_dotdot() instead of a manual "."/".." check
The is_dot_or_dotdot() is used to check if the string is either "." or "..".
It's pretty obvious what this function does, so it's not necessary to explain it.
Include the "dir.h" header file to use is_dot_or_dotdot().
Including dir.h is a obvious requirement of using is_dot_or_dotdot(), thus also does not require explanation. Otherwise, the patch looks fine.
quoted hunk ↗ jump to hunk
Signed-off-by: Hiroyuki Sano <redacted> --- diff-no-index.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)diff --git a/diff-no-index.c b/diff-no-index.c index 20b6a8a..8e642b3 100644 --- a/diff-no-index.c +++ b/diff-no-index.c@@ -11,6 +11,7 @@ #include "tag.h" #include "diff.h" #include "diffcore.h" +#include "dir.h" #include "revision.h" #include "log-tree.h" #include "builtin.h"@@ -25,7 +26,7 @@ static int get_path_list(const char *path, struct string_list *list) return error("Could not open directory %s", path); while ((e = readdir(dir))) - if (strcmp(".", e->d_name) && strcmp("..", e->d_name)) + if (!is_dot_or_dotdot(e->d_name)) string_list_insert(list, e->d_name); closedir(dir); --1.9.0