Re: [PATCH] general style: replaces memcmp() with starts_with()

On 03/12/2014 03:06 PM, Quint Guvernator wrote:

2014-03-12 9:51 GMT-04:00 Duy Nguyen [off-list ref]:

quoted

starts_with(..) == !memcmp(...). So
you need to negate every replacement.

My apologies--it doesn't look like the tests caught it either. I will
fix this and submit a new patch.

It is very, very unlikely that you inverted the sense of dozens of tests
throughout the Git code base and the tests ran correctly.  I rather
think that you made a mistake when testing.  You should double- and
triple-check that you really ran the tests and ran them correctly.

Michael

-- 
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/