Thread (10 messages) flat view 10 messages, 5 authors, 2016-06-15

Re: [PATCH] general style: replaces memcmp() with starts_with()

From: Duy Nguyen <hidden>
Date: 2016-06-15 23:00:17

On Wed, Mar 12, 2014 at 8:44 PM, Quint Guvernator
[off-list ref] wrote:
quoted hunk ↗ jump to hunk
diff --git a/builtin/apply.c b/builtin/apply.c
index a7e72d5..8f21957 100644
--- a/builtin/apply.c
+++ b/builtin/apply.c
@@ -846,8 +846,8 @@ static int has_epoch_timestamp(const char *nameline)
         * YYYY-MM-DD hh:mm:ss must be from either 1969-12-31
         * (west of GMT) or 1970-01-01 (east of GMT)
         */
-       if ((zoneoffset < 0 && memcmp(timestamp, "1969-12-31", 10)) ||
-           (0 <= zoneoffset && memcmp(timestamp, "1970-01-01", 10)))
+       if ((zoneoffset < 0 && starts_with(timestamp, "1969-12-31")) ||
+           (0 <= zoneoffset && starts_with(timestamp, "1970-01-01")))
                return 0;
It is not a plain search/replace. starts_with(..) == !memcmp(...). So
you need to negate every replacement.
-- 
Duy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help