Re: Make the git codebase thread-safe

On Thu, Feb 13, 2014 at 2:51 PM, Karsten Blees [off-list ref] wrote:

Am 13.02.2014 19:38, schrieb Zachary Turner:

quoted

The only reason ReOpenFile is necessary at
all is because some code somewhere is mixing read-styles against the same
fd.

I don't understand...ReadFile with OVERLAPPED parameter doesn't modify the HANDLE's file position, so you should be able to mix read()/pread() however you like (as long as read() is only called from one thread).

That is, apparently, a bald-faced lie in the ReadFile API doc.  First
implementation didn't use ReOpenFile, and it crashed all over the
place.  ReOpenFile fixed it.

Stefan